[Pdns-users] pdnssec.cc patch + other stuff

[Craig Whitmore]

Looking thru the code for pdnssec.cc there looks like there is a lot of
error checking missing which can cause it to seg-fault when typing the wrong
number of arguments.

I have made a patch which fixes this and does a few more things..
* checks the number of arguments is correct for all commands
* Removes order-zone command as it doesn't seem its used (rectify-zone does
the same thing)
* If wrong number of arguments shows usage in a standard format
* If there is a synax error actually doesn't continue and seg fault
* Fixes a spelling mistake and right number or arguments in showing usage
It seems to work but someone else might want to double check it.

Also (as not documented)
test-speed? seg faults when I run it .. It seems have something to do with
signing-server/slave as below
verify-crypto ? How does it work.. No docs
signing-server/signing-slave  ? All commented out?
Lots of else if. Better/faster to use case statements?

Also there is no way to know when a KSK/ZSK is going to expire or even set
it ? Key life time? So you can roll over before it expires.

Thanks
Craig






-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.powerdns.com/pipermail/pdns-users/attachments/20110615/8faf3fb5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pdnssec.cc.diff
Type: application/octet-stream
Size: 7059 bytes
Desc: not available
URL: <http://mailman.powerdns.com/pipermail/pdns-users/attachments/20110615/8faf3fb5/attachment.obj>