<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; "><div>Looking thru the code for pdnssec.cc there looks like there is a lot of error checking missing which can cause it to seg-fault when typing the wrong number of arguments.</div><div><br></div><div>I have made a patch which fixes this and does a few more things..</div><ul><li>checks the number of arguments is correct for all commands</li><li>Removes order-zone command as it doesn't seem its used (rectify-zone does the same thing)</li><li>If wrong number of arguments shows usage in a standard format</li><li>If there is a synax error actually doesn't continue and seg fault</li><li>Fixes a spelling mistake and right number or arguments in showing usage</li></ul><div>It seems to work but someone else might want to double check it.</div><div><br></div><div>Also (as not documented) </div><div>test-speed? seg faults when I run it .. It seems have something to do with signing-server/slave as below</div><div>verify-crypto ? How does it work.. No docs</div><div>signing-server/signing-slave ? All commented out?</div><div>Lots of else if. Better/faster to use case statements?</div><div><br></div><div>Also there is no way to know when a KSK/ZSK is going to expire or even set it ? Key life time? So you can roll over before it expires.</div><div><br></div><div>Thanks</div><div>Craig</div><div><br></div><div><br></div><div><br></div><div><br></div></body></html>