[dnsdist] pool selection without implicit accept

Klaus Darilion klaus.mailinglists at pernau.at
Fri Jul 12 14:15:24 UTC 2019



Am 12.07.2019 um 16:08 schrieb Remi Gacogne:
> 
> 
> On 7/12/19 2:52 PM, Klaus Darilion wrote:
>> That does not work. At the moment, if I want to add another domain (ie
>> rate1.com) to the "static" pool I have to check first, if the domain is
>> rate limited or not, and if yes, use a andAction construct to achieve my
>> goal. So, yes it would be possible, the complex to manage.
> 
> You are right, while Pieter's solution would work it increases the
> complexity a bit. Since it's not the first time I would like to be able
> to apply an existing action without stopping the processing, I'm
> considering implementing a ContinueAction() action that would accept an
> existing action as parameter, execute it and return None, regardless of
> the value returned by the existing action.
> 
> That would make it possible to do something like that in a generic way:
> 
> addAction({ 'rate1.com','aaaaa.aa' }, ContinueAction(PoolAction("static")))
> 
> I don't think it would be too complicated to implement and since it
> would be self-contained we could even consider it for 1.4.0.
> 
> Any thoughts?

Sounds like a useful hack.

Although I think the otherway round would be better, ie:

addAction({ 'rate1.com','aaaaa.aa' }, PoolAction("static") && AllowAction())

with default "continue" for PoolAction, but I guess for such changes it
it a few years to late.

Thanks
Klaus


More information about the dnsdist mailing list