recursor 3.1.7 Makefile broken, was: [Pdns-users] PowerDNS Recursor 3.1.7 released - with DNS scripting!

[J Knight]

On 8/10/2008 at 12:00 PM, "J Knight" <jknight+pdns at spamshield.org> wrote:

> On 6/25/2008 at 4:12 AM, "bert hubert" <bert.hubert at netherlabs.nl> wrote:

>> Available on:
>>  http://downloads.powerdns.com/releases/pdns-recursor-3.1.7.tar.bz2

> oddly enough, this built fine on FreeBSD6.2-RELEASE with gmake = GNU Make 3.81

> when I tried to compile this on a RH ES3, with gmake = GNU Make version 3.79.1,
> I'd get:

>> Testing dependencies and compiler.
>> Using gmake to build
>> Makefile:45: Extraneous text after `else' directive
>> Makefile:48: *** only one `else' per conditional.  Stop.

> Seemingly a missing 'endif' - but I am wondering why the newer gmake just completely
> ignored this?

> Fixed with:

> *** Makefile.dist       2008-06-24 14:23:33.000000000 -0400
> --- Makefile    2008-08-10 11:59:50.000000000 -0400
> ***************
> *** 43,52 ****
>         LINKCC=$(CC)
>         LDFLAGS += malloc.o -ldl -lm
>   else ifeq ($(STATIC),full)
> !       STATICFLAGS=-lstdc++ $(LUALIBS) -ldl -lm -static
> !       LINKCC=$(CC)
> ! else
> !       LDFLAGS += malloc.o $(LUALIBS)
>   endif


> --- 43,53 ----
>         LINKCC=$(CC)
>         LDFLAGS += malloc.o -ldl -lm
>   else ifeq ($(STATIC),full)

OOPS!


> !               STATICFLAGS=-lstdc++ $(LUALIBS) -ldl -lm -static
> !               LINKCC=$(CC)
> !       else
> !               LDFLAGS += malloc.o $(LUALIBS)
> !       endif
>   endif


> Thanks,
> Jamie


I messed up the above - I had joined the "else ifeq ($(STATIC),full)" statement into
a single line - but that doesn't work, the "else" and "ifeq" statements must be on
different lines for gmake to understand:


*** Makefile.dist       2008-06-24 14:23:33.000000000 -0400
--- Makefile    2008-08-10 12:51:33.000000000 -0400
***************
*** 42,52 ****
        STATICFLAGS=-Wl,-Bstatic -lstdc++ $(LUALIBS) -lgcc -Wl,-Bdynamic -static-libgcc -lm -lc
        LINKCC=$(CC)
        LDFLAGS += malloc.o -ldl -lm
- else ifeq ($(STATIC),full)
-       STATICFLAGS=-lstdc++ $(LUALIBS) -ldl -lm -static
-       LINKCC=$(CC)
  else
!       LDFLAGS += malloc.o $(LUALIBS)
  endif


--- 42,54 ----
        STATICFLAGS=-Wl,-Bstatic -lstdc++ $(LUALIBS) -lgcc -Wl,-Bdynamic -static-libgcc -lm -lc
        LINKCC=$(CC)
        LDFLAGS += malloc.o -ldl -lm
  else
!       ifeq ($(STATIC),full)
!               STATICFLAGS=-lstdc++ $(LUALIBS) -ldl -lm -static
!               LINKCC=$(CC)
!       else
!               LDFLAGS += malloc.o $(LUALIBS)
!       endif
  endif