[Pdns-dev] TLSA certificate field type is incorrect

[James Cloos]

>>>>> "PL" == Pieter Lexis <pieter.lexis at os3.nl> writes:

PL> Index: pdns/dnsrecords.cc
PL> ===================================================================
PL> --- pdns/dnsrecords.cc	(revision 2346)
PL> +++ pdns/dnsrecords.cc	(working copy)
PL> @@ -227,7 +227,7 @@
PL>          	 conv.xfr8BitInt(d_certusage);
PL>          	 conv.xfr8BitInt(d_selector);
PL>          	 conv.xfr8BitInt(d_matchtype);
PL> -        	 conv.xfrBlob(d_cert);
PL> +        	 conv.xfrHexBlob(d_cert, true); // keep reading across spaces
PL>          	 )
PL> 
PL>  #undef DS

I didn't get that far in my testing.

After looking at other RRs in the code and in the RFCs and drafts, I see
that xfrBlob is used where the blob is supposed to be in base64 and that
xfrHexBlob is used when it should be in hex.  So, 

Reviewed-by: James Cloos <cloos at jhcloos.com>

-JimC
-- 
James Cloos <cloos at jhcloos.com>         OpenPGP: 1024D/ED7DAEA6