[Pdns-dev] Re: 2.9.12 delayed because of bugs in the assembler

Christof Meerwald cmeerw at web.de
Sat Oct 4 10:04:46 CEST 2003

On Fri, 3 Oct 2003 23:31:53 +0200, bert hubert wrote:
> On Fri, Oct 03, 2003 at 10:36:06PM +0200, Christof Meerwald wrote:
>> Please have another look at the code and give it a second thought:
> Thanks for spotting this. Must've been a pretty bad brainfart. I even
> remember testing this.
> Doh.
> New version, please check:

Well, but IMHO IpToU32 doesn't server any useful purpose, so I would rather
completely remove it and invoke Utility::inet_aton in pdns_recursor.cc
directly. Use 

    if(!Utility::inet_aton(arg()["local-address"].c_str(), &sin.sin_addr))

instead of the call to IpToU32 in makeTCPServerSocket and makeServerSocket.

bye, Christof

http://cmeerw.org                                 JID: cmeerw at jabber.at
mailto cmeerw at web.de

More information about the Pdns-dev mailing list