[dnsdist] [Pdns-users] Fourth release candidate for dnsdist 1.5.0

[Otto Moerbeek]

On Sun, Jul 19, 2020 at 12:29:05PM +0200, Stephane Bortzmeyer via Pdns-users wrote:

> On Tue, Jul 07, 2020 at 04:41:00PM +0200,
>  Remi Gacogne via dnsdist <dnsdist at mailman.powerdns.com> wrote 
>  a message of 84 lines which said:
> 
> > While we expected the third release candidate for dnsdist 1.5.0 to be
> > the last one, a race condition that could lead to a crash was discovered
> > by Tomas Krizek from CZ.NIC with the DNS Shotgun tool, leading to a new
> > release candidate.
> 
> Does not compile:
> 
>   CXX      doh.o
> doh.cc: In function ‘void doh_dispatch_query(DOHServerConfig*, h2o_handler_t*, h2o_req_t*, std::string&&, const ComboAddress&, const ComboAddress&, std::string&&)’:
> doh.cc:677:24: error: expected primary-expression before ‘=’ token
>   677 |     const char * sni = = h2o_socket_get_ssl_server_name(sock);
>       |                        ^
> make[2]: *** [Makefile:1351: doh.o] Error 1
> make[2]: Leaving directory '/home/stephane/DoH/dnsdist/dnsdist-1.5.0-rc4'
> make[1]: *** [Makefile:1478: all-recursive] Error 1
> make[1]: Leaving directory '/home/stephane/DoH/dnsdist/dnsdist-1.5.0-rc4'
> make: *** [Makefile:1109: all] Error 2
> nice make  689.79s user 101.42s system 95% cpu 13:48.71 total
> 
> I had no problem with all the 1.5.0rc* before.
> 
> Arch Linux, x86_64
> 
> % g++ -v
> Using built-in specs.
> COLLECT_GCC=g++
> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/lto-wrapper
> Target: x86_64-pc-linux-gnu
> Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++,d --with-isl --with-linker-hash-style=gnu --with-system-zlib --enable-__cxa_atexit --enable-cet=auto --enable-checking=release --enable-clocale=gnu --enable-default-pie --enable-default-ssp --enable-gnu-indirect-function --enable-gnu-unique-object --enable-install-libiberty --enable-linker-build-id --enable-lto --enable-multilib --enable-plugin --enable-shared --enable-threads=posix --disable-libssp --disable-libstdcxx-pch --disable-libunwind-exceptions --disable-werror gdc_include_dir=/usr/include/dlang/gdc
> Thread model: posix
> Supported LTO compression algorithms: zlib zstd
> gcc version 10.1.0 (GCC) 

Thanks for the report. It seems an unfortunate typo slipped in. We
need to figure out why this wasn't caught in our QA.

Removing the extra assignment opetor should work. 

Regards, Otto