[Pdns-users] PowerDNS notify Patch

[Cemil Degirmenci]

Hi There,

There is a wellknown Issue which is not very fine, but also not very
important. PowerDNS notifies itself when you make "pdns_control notify
domainname"

There is a Patch for this issue.


diff -rNu pdns-2.9.16/pdns/communicator.cc
pdns-2.9.16-notify_fix/pdns/communicator.cc
--- pdns-2.9.16/pdns/communicator.cc    Sun May 25 14:38:48 2003
+++ pdns-2.9.16-notify_fix/pdns/communicator.cc Sun Mar 21 12:34:38 2004
@@ -148,6 +148,9 @@
    DNSResourceRecord rr;
    set<string>nsset;

+  vector<string>locals;
+  stringtok(locals,arg()["local-address"]," ,");
+
    B->lookup(QType(QType::NS),domain);
    while(B->get(rr))
      nsset.insert(rr.content);
@@ -162,8 +165,12 @@

    // make calls to d_nq.add(domain, ip);
    for(set<string>::const_iterator j=ips.begin();j!=ips.end();++j) {
-    L<<Logger::Warning<<"Queued notification of domain '"<<domain<<"'
to "<<*j<
<endl;
-    d_nq.add(domain,*j);
+    for(vector<string>::const_iterator
laddr=locals.begin();laddr!=locals.end()
;++laddr) {
+      if(*laddr != *j) {
+        L<<Logger::Warning<<"Queued notification of domain
'"<<domain<<"' to "<
<*j<<endl;
+        d_nq.add(domain,*j);
+      }
+    }
    }

    set<string>alsoNotify;


So i have some questions... Is this patch in the recent cvs tree? Has it
sence to implement it? It works well for me with 2.9.16

-- 
Mit freundlichen Gruessen / kind regards,

Cemil Degirmenci
wavecon.de - CEO