[Pdns-dev] Re: 2.9.12 delayed because of bugs in the assembler

Christof Meerwald cmeerw at web.de
Fri Oct 3 23:36:06 CEST 2003


On Thu, 2 Oct 2003 19:52:08 +0200, bert hubert wrote:
> The formal release of pdns 2.9.12 is held up by:
[...]

> Changelog:
[...]
>      * pdns_recursor would try to resolve IP address which to bind to,
>        potentially causing chicken/egg problem

Please have another look at the code and give it a second thought:

bool IpToU32(const string &str, u_int32_t *ip)
{
  int a,b,c,d;
  if(sscanf(str.c_str(),"%d.%d.%d.%d",&a, &b, &c, &d)!=4)
    return false;
  *ip++=a;
  *ip++=b;
  *ip++=c;
  *ip++=d;
  return true;
}


Obviously, this code is wrong and I wonder why inet_aton is not used
instead.


bye, Christof

-- 
http://cmeerw.org                                 JID: cmeerw at jabber.at
mailto cmeerw at web.de


More information about the Pdns-dev mailing list